Code

Modbus rework#9141

Code

Merged

ssoroka merged 35 commits intoinfluxdata:masterinfluxdata/telegraf:masterfrom HRI-EU:modbus_reworkHRI-EU/telegraf:modbus_reworkCopy head branch name to clipboardMay 27, 2021

+1,555-678

Commits

Commits on May 18, 2021

• Move to maintained 'github.com/grid-x/modbus' almost drop-in replacement.

  

  Sven Rebhan

  committed
  b01e08d

  Copy full SHA for b01e08d

• Reorganize modbus plugin code to factor out time-conversions and config handling.

  

  Sven Rebhan

  committed
  da20f23

  Copy full SHA for da20f23

• Move type conversion handling to separate files for maintainability.

  

  Sven Rebhan

  committed
  b01e144

  Copy full SHA for b01e144

• Factor out configuration handling and type-conversion initialization.

  

  Sven Rebhan

  committed
  c31392c

  Copy full SHA for c31392c

• Rename 'register' type to 'request' as this better reflects what it is.

  

  Sven Rebhan

  committed
  6c92cf6

  Copy full SHA for 6c92cf6

• Move from 'assert' to 'require' for testing.

  

  Sven Rebhan

  committed
  db010d9

  Copy full SHA for db010d9

• Change construction of requests such that each request represents a request on the wire with a consecutive set of register addresses.

  

  Sven Rebhan

  committed
  5892fe3

  Copy full SHA for 5892fe3

• Add test for field-definition with holes in the address ranges.

  

  Sven Rebhan

  committed
  5410b2f

  Copy full SHA for 5410b2f

• Simplify register init in the original configuration.

  

  Sven Rebhan

  committed
  1ddcd81

  Copy full SHA for 1ddcd81

• Simplify getFields() method.

  

  Sven Rebhan

  committed
  1b6dcbb

  Copy full SHA for 1b6dcbb

• Also make the non-exported structs' fields private.

  

  Sven Rebhan

  committed
  12a77bd

  Copy full SHA for 12a77bd

• Simplify connection handling and de-entangle configuration processing.

  

  Sven Rebhan

  committed
  1b01f39

  Copy full SHA for 1b01f39

• Rework request initialization and factor out requests.

  

  Sven Rebhan

  committed
  ea66c93

  Copy full SHA for ea66c93

• Cleanup testing and switch to metric-based testing.

  

  Sven Rebhan

  committed
  3bce242

  Copy full SHA for 3bce242

• Prepare handling of multiple slave-devices.

  

  Sven Rebhan

  committed
  dd21275

  Copy full SHA for dd21275

• Formatting.

  

  Sven Rebhan

  committed
  c58291b

  Copy full SHA for c58291b

• Shorten code a bit.

  

  Sven Rebhan

  committed
  7bf3a4c

  Copy full SHA for 7bf3a4c

• Move non-exported functions to the end of the file.

  

  Sven Rebhan

  committed
  f5f8381

  Copy full SHA for f5f8381

• Fix linter issues in configuration handling.

  

  Sven Rebhan

  committed
  beeb493

  Copy full SHA for beeb493

• Fix linter issues in requests.

  

  Sven Rebhan

  committed
  98ee3e4

  Copy full SHA for 98ee3e4

• Fix linter issues in type-conversions.

  

  Sven Rebhan

  committed
  91884cf

  Copy full SHA for 91884cf

• Fix license documentation.

  

  Sven Rebhan

  committed
  3c6f3ca

  Copy full SHA for 3c6f3ca

• Restore the original type conversion logic.

  

  Sven Rebhan

  committed
  13c0e16

  Copy full SHA for 13c0e16

• Fix linter issue in type-conversion.

  

  Sven Rebhan

  committed
  b0e91c8

  Copy full SHA for b0e91c8

• Add trouble-shooting section to readme.

  

  Sven Rebhan

  committed
  33d4e84

  Copy full SHA for 33d4e84

• Add debug output to see the raw-values read from the registers.

  

  Sven Rebhan

  committed
  6049c08

  Copy full SHA for 6049c08

• Extend debug output to also see the resulting value.

  

  Sven Rebhan

  committed
  1e6fb83

  Copy full SHA for 1e6fb83

• Add logger during test and change Debug to Debugf.

  

  Sven Rebhan

  committed
  4183264

  Copy full SHA for 4183264

• Allow tracing the connection to debug connectivity problems. This is done to avoid extensive logs during standard debug. Please note, you need to enable both, 'trace_connection=true' as well as deb…

  Show description for 39c227b
  

  Sven Rebhan

  committed
  39c227b

  Copy full SHA for 39c227b

• Add option to close the connection after each gather cycle and force it to 'true' for serial connections.

  

  Sven Rebhan

  committed
  c3ff22b

  Copy full SHA for c3ff22b

• Revert "Add option to close the connection after each gather cycle and force it to 'true' for serial connections." to not clutter this PR. Will add another PR instead.

  Show description for 253ddcc
  

  Sven Rebhan

  committed
  253ddcc

  Copy full SHA for 253ddcc

• Revert "Allow tracing the connection to debug connectivity problems. This is done to avoid extensive logs during standard debug. Please note, you need to enable both, 'trace_connection=true' as wel…

  Show description for efabb1a
  

  Sven Rebhan

  committed
  efabb1a

  Copy full SHA for efabb1a

• Add more debug messages to debug influxdata#8506.

  

  Sven Rebhan

  committed
  6658954

  Copy full SHA for 6658954

Commits on May 19, 2021

• Add test case for non-consecutive coils.

  

  Sven Rebhan

  committed
  4ce9a1e

  Copy full SHA for 4ce9a1e

Commits on May 27, 2021

• Remove unused slaveID variable.

  

  Sven Rebhan

  committed
  41c9793

  Copy full SHA for 41c9793