Add HTTP proxy to datadog output #9297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrantz01
added
feat
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
srebhan
reviewed
May 25, 2021
plugins/outputs/datadog/README.md
Outdated
| @@ -16,6 +16,9 @@ This plugin writes to the [Datadog Metrics API][metrics] and requires an | |||
|
|
|||
| ## Write URL override; useful for debugging. | |||
| # url = "https://app.datadoghq.com/api/v1/series" | |||
|
|
|||
| ## Set http_proxy (telegraf uses the system wide proxy settings if it's is not set) | |||
There was a problem hiding this comment.
Typo. Same in sampleConfig
Suggested change
| ## Set http_proxy (telegraf uses the system wide proxy settings if it's is not set) | |
| ## Set http_proxy (telegraf uses the system wide proxy settings if it isn't set) |
srebhan
reviewed
May 25, 2021
There was a problem hiding this comment.
@akrantz01 thanks for adding this feature. I found two typos, but the change looks good code-wise.
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
srebhan
added
the
ready for final review
ssoroka
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #8388
Added configuring a HTTP proxy for the DataDog output through the config file.