fix: bump thrift to 0.14.2 and zipkin-go-opentracing 0.4.5 #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimda
approved these changes
Sep 2, 2021
sspaink
approved these changes
Sep 2, 2021
akrantz01
force-pushed
the
9657-apache-thrift
branch
from
0816d74 to
963fc4a
Compare
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9657
This is not a trivial version bump for two reasons: thrift changed the generated code to now take a context as an argument, and zipkin no longer recommends using thrift, so they do not package the generated code in a library. We now generate our own thrift bindings in
codec/thrift/gen-go/zipkincore. In addition, openzipkin/zipkin-go-opentracing was renamed to openzipkin-contrib/zipkin-go-opentracing and had some things moved into openzipkin/zipkin-go.