Fix #44: Properly counting lines on Windows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wrong counting of lines on Windows. Main intention is to fix Telegraf config tests on Windows.
Note, several tests are failing on Windows, mainly due to the line endings differences.
This fix fixes one of these tests.
This is a copy of PR #45 in the original toml repo, where there is no response for long time. This PR adds a dedicated test for line counting error on top of that.
This PR is created intentionally to the
telegrafbranch, because amending fix for master was too cumbersome.