fix: prevent invisible tooltips for the zero value of legendOpacity from the api #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
suggested changes
Sep 24, 2020
| return LEGEND_OPACITY_DEFAULT | ||
| }, [legendOpacity]), | ||
| LEGEND_OPACITY_MINIMUM | ||
| ) |
There was a problem hiding this comment.
All of these are doing the exact same thing. I would pull them out into their own hook with a useCallback whose dependency array is contains legendOpacity. Then each of these files would read something like:
const tooltipOpacity = useLegendOpacity(legendOpacity)
There was a problem hiding this comment.
Ok, will do.
Also, unrelated. A better default is a solid looking tooltip rather than a barely visible 0.2
121watts
approved these changes
Sep 24, 2020
TCL735
force-pushed
the
fix_legend_opacity_zero_value
branch
from
aa8280a to
0d69307
Compare
|
The force push was to fix merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial value from the backend api comes back as 0 for opacity, which doesn't change in props, causing legends to appear invisible. Prevent this by ensuring minimum opacity is always used.