Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependencies #155

Closed
wants to merge 1 commit into from
Closed

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 7, 2024

Description

Update dev-dependencies indoc and async-std

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,reqwest-client-rustls -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo doc2readme -p influxdb --expand-macros
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@msrd0
Copy link
Collaborator

msrd0 commented Sep 20, 2024

Is there a particular reason for updating async-std to a semver-compatible version? Do we need any features/bugfixes introduced since the version we specified?

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 25, 2024

The main feature is async-std now has I/O safe traits sunfishcode/io-lifetimes#38 , but there are also many other bug fixes since async-std v1.6.5 which was released 4 years ago, including several panics.

@Empty2k12 Empty2k12 force-pushed the main branch 12 times, most recently from c241371 to 359fd08 Compare December 13, 2024 17:35
@msrd0
Copy link
Collaborator

msrd0 commented Jan 23, 2025

Unless our code makes use of the new I/O safe traits or any other features introduced between the minimal version we specified and the minimal version this PR updates it to, there is no point. Cargo will already pick newer versions when available and compatible, so we shouldn't update the version because it is 4 years old, but only if we used features introduced in newer versions.

@msrd0 msrd0 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants