modules: Clean up modules' errors

[yito88]

Closes: informalsystems/ibc-rs#72
based on #1283

Description

• Add Ics02Error and Ics03Error to Ics04Error
• Give the port ID and the channel ID to MissingNext*Seq error
• Remove redundant errors

---

For contributor use:

• Added a changelog entry, using unclog.
• If applicable: Unit tests written, added test to CI.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments.
• Re-reviewed Files changed in the Github PR explorer.

[adizere]

One more remark @yito88: your contributions are very valuable and we're very thankful! I think you will receive rights (cc @romac) to open branches in this repository, unless you can already do that. In future PRs, could you consider opening merges from a branch in this repo (as opposed to your own fork)? That would slightly improve reviewing experience since it will make it easier for us to switch to your dev branch and read code on own local copy.

Edit: I stand corrected. We'll talk within Informal and there may be org-level restrictions about allowing non-org members to write to our repos. We may need to continue with the same approach as we currently do (i.e., continue opening PRs from the fork). Also, Romain drew my attention to gh which can help alleviate the burden of checking out locally branches from forks.

[hu55a1n1]

Thanks @yito88! Just one more thing - compilation is currently failing for tests. Here's a fix ->

diff --git a/modules/src/ics04_channel/handler/chan_open_try.rs b/modules/src/ics04_channel/handler/chan_open_try.rs
index dd71eb65..5191e0ef 100644
--- a/modules/src/ics04_channel/handler/chan_open_try.rs
+++ b/modules/src/ics04_channel/handler/chan_open_try.rs
@@ -370,12 +370,16 @@ mod tests {
                 msg: ChannelMsg::ChannelOpenTry(msg.clone()),
                 want_pass: false,
                 match_error: Box::new(|e| match e {
-                    error::ErrorDetail::Ics02Client(e) => {
+                    error::ErrorDetail::Ics03Connection(e) => {
                         assert_eq!(
                             e.source,
-                            ics02_error::ErrorDetail::ClientNotFound(
-                                ics02_error::ClientNotFoundSubdetail {
-                                    client_id: ClientId::new(ClientType::Mock, 45).unwrap()
+                            ics03_error::ErrorDetail::Ics02Client(
+                                ics03_error::Ics02ClientSubdetail {
+                                    source: ics02_error::ErrorDetail::ClientNotFound(
+                                        ics02_error::ClientNotFoundSubdetail {
+                                            client_id: ClientId::new(ClientType::Mock, 45).unwrap()
+                                        }
+                                    )
                                 }
                             )
                         );

Once #1283 is merged, it would be great if you could rebase on/merge with master.

[yito88]

Thank you for reviewing and fixing!
I've rebased on master.

[adizere]

Nice idea to consolidate the errors like this. Great work!

[adizere]

This is a bit of a mouthful, but on the other hand, it's good we can decompose the error here and assert on the precise details. This is just a remark, not a suggestion for any change.