-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to ibc_proto v.0.3.0 #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo some typos and a couple idioms :) Will leave it to @adizere to approve the PR as I am not super familiar with ICS 03 yet.
Heads-up, once we merge #220 we might get the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think clippy
will bite us with next commits, so we'll need to address that (see my earlier comment). Otherwise looks good!
Another need to fix before merge: When running the Rust relayer query with Gaia and Go Relayer, the connection query fails.
The failure is here: The query works on master (with ibc-proto v.0.1.0), the protobuf for The channel query that gets a |
* Fix Clippy warnings * Add stub for deserializing ClientState from Protbuf's Any * Update to latest ibc-proto * Decode Tendermint client state from raw * Decode raw client states * Add FIXME comments to uses of `epoch_height` * Update ibc-proto to 0.3.0 * Remove local path to ibc-proto dependency * Stylistic fixes
50c956c
to
1e1a339
Compare
Closes: #226
Description
Migrate to ibc_proto v0.3.0.
Includes minimal changes such that the code compiles and tests pass. In particular:
Height
is ignored and the deserialization code only extracts theEpochHeight
in the currentHeight
type which is u64.For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer