Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for fee modules tests #2757

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add docs for fee modules tests #2757

merged 2 commits into from
Oct 25, 2022

Conversation

seanchen1991
Copy link
Contributor

Closes: #2756

Description

Adds documentation for the fee module integration tests that somehow didn't get committed as part of #1981.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 added the O: ics29-fee Objective: Fee middleware support label Oct 24, 2022
@seanchen1991 seanchen1991 requested a review from ljoss17 October 24, 2022 17:11
@seanchen1991 seanchen1991 self-assigned this Oct 24, 2022
ljoss17
ljoss17 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !!

@romac romac merged commit cead6c3 into master Oct 25, 2022
@romac romac deleted the ics29-integration-test-docs branch October 25, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

@romac romac romac approved these changes

Assignees

@seanchen1991 seanchen1991

Labels
O: ics29-fee Objective: Fee middleware support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for ICS29 integration tests
3 participants
@seanchen1991 @romac @ljoss17