-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tasks spawned by CLI commands into their own modules #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks cleaner than before!
Some suggestion to try to further improve this (defer to next iteration of work towards #330):
- I suspect
relayer-cli/src/commands/utils.rs
can be deleted - it would improve readability if all files in
commands.rs
have the same structure: definition ofpub struct xyzCmd
, then implementation of that struct, thenimpl Runnable for xyzCmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, I had nothing to comment.
So |
It never did that AFAIK. |
Just checked, it did before #255, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Right, my bad! Since we are going to rewrite this code for v0 anyway, it doesn't really matter so I guess we can just go ahead and merge this. |
…ystems#331) * Cleanup listen and start commands * Better error handling in listen command * Move event listener code into its own task module * Move light client and relayer tasks into their own modules * Remove light client config file from Git * Remove local config file * Add doc comments to light client and relayer tasks * Remove unused import * Remove unused utils module * Remove unused lint * Reorder code blocks * Update changelog
First small step towards #330
Description
Split tasks spawned by CLI commands into their own modules.
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer