Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #208 and #210 to main #215

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Port #208 and #210 to main #215

merged 3 commits into from
Jan 9, 2025

Conversation

p-offtermatt
Copy link
Member

@p-offtermatt p-offtermatt commented Jan 8, 2025

Description

Port #208 and #210 into main

Add a description of the changes that this PR introduces and the files that
are the most critical to review.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

* Add per tranche info for lockups

* Add PR number

* Transform next_round_voting_allowed to be more legible

* Add test for per_tranche info on lockups

* Appease clippy

* Fix minor issues

* Make comments more detailed

* Regenerate artifacts

* Restructure logic for skipping tranche

* Regenerate artifacts
* Separate PerTrancheInfos into separate query

* Regenerate artifacts

* Recompile contract

* Add new message to schema
@p-offtermatt p-offtermatt requested a review from a team as a code owner January 8, 2025 15:32
@p-offtermatt p-offtermatt merged commit f036ec9 into main Jan 9, 2025
4 checks passed
@p-offtermatt p-offtermatt deleted the ph/port-208-210 branch January 9, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants