-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/proto-compiler
output does not compile on current master
#1014
Comments
I think this can be fixed as follows:
|
I can successfully reproduce this. Seem as though it may have something to do with this line that gets removed when I re-run proto-compiler: tendermint-rs/proto/src/tendermint.rs Line 56 in 858b577
I'll have to look into why it's removing that line though. |
Oh it's probably because that line was added manually 😄 Damn. I'll look into fixing this. |
Signed-off-by: Thane Thomson <[email protected]>
* Make Vec method reference absolute to fix #1014 Signed-off-by: Thane Thomson <[email protected]> * Regenerate protos with proto-compiler Signed-off-by: Thane Thomson <[email protected]> * Add experimental CI job to test that generated protos compile Signed-off-by: Thane Thomson <[email protected]> * Try alternative approach to `uses` with `working-directory` Signed-off-by: Thane Thomson <[email protected]> * Add changelog entry Signed-off-by: Thane Thomson <[email protected]>
Steps to reproduce
tendermint-rs
cargo test
; it succeedscd tools/proto-compiler && cargo run && cd ../..
; succeedscargo test
fails, as the output no longer compiles:My best guess is that this is a
no_std
-related issue but I don't actually know.What's the definition of "done" for this issue?
proto-compiler
to produce working code;The text was updated successfully, but these errors were encountered: