Harmonize on proto-types for representing well-known protobuf message types #1053
Labels
domain-types
Anything relating to the creation, modification or removal of domain types
enhancement
New feature or request
serialization
technical debt
Issues that are important, but not urgent, that should eventually receive attention
Version(s) of tendermint-rs: v0.23.2, master
Description
There is code in ibc-rs that jumps through hoops for the sole reason that the protobuf message structures generated for IBC use
proto-types
, whiletendermint-proto
includes a homespun variant of structures representinggoogle.protobuf
.This was done in #639 which predates the rearchitecting with domain types and derives serde impls directly on the protobuf message types. This is less preferable than putting the serde concern cleanly onto the domain types, since only the latter can enforce value validity.
Definition of "done"
tendermint-proto
usesproto-types
to representTimestamp
,Duration
, and possibly other well-known message types.The corresponding domain types in
tendermint
respond to all serde needs.The text was updated successfully, but these errors were encountered: