Protobuf well-known types unnecessarily generated #1188
Labels
breaking
enhancement
New feature or request
technical debt
Issues that are important, but not urgent, that should eventually receive attention
Description
The proto compiler enables the
compile_well_known_types
setting in prost-build configuration, and the generatedgoogle.protobuf.rs
content is included intotendermint-proto
under thegoogle::protobuf
path, with the exception ofDuration
andTimestamp
that get special manually maintained struct definitions. In fact, no other well-known types are referenced by any proto message definitions in Tendermint, so the generated content is unnecessary. Additionally, since the WKT definitions are provided with the compiler, this creates a subtle dependency on the protoc compiler installation that may result in "jitter" in the public tendermint-proto API.Definition of "done"
The generated structs are removed from
google::protobuf
, onlyDuration
andTimestamp
are left to be manually maintained (pending resolution of #1053).The text was updated successfully, but these errors were encountered: