Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check hash of consensus params in the LightClient and in tests #480

Open
andrey-kuprianov opened this issue Jul 27, 2020 · 0 comments
Open

Check hash of consensus params in the LightClient and in tests #480

andrey-kuprianov opened this issue Jul 27, 2020 · 0 comments
Labels
light-client Issues/features which involve the light client tests

Comments

@andrey-kuprianov
Copy link
Contributor

andrey-kuprianov commented Jul 27, 2020 •
edited
Loading

Currently LightClient doesn't perform any checks on the header's hash of consensus parameters. We need to add this check, and also to reflect it in the tests, in particular in tendermint-testgen #393.

This is the hash of the consensus params which light clients currently don't pay attention to but which can change (though very infrequently) in the life of a blockchain. Best to open a follow up issue for things like this

Originally posted by @ebuchman in #468 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
light-client Issues/features which involve the light client tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrey-kuprianov