-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator of Tendermint types for unit, integration, and model-based testing #468
Conversation
* refactor produce_validator to allow calling it from within Rust code, to easily produce Info struct * add --ignore-stdin option to allow skipping parsing from STDIN
Just want to emphasize how good the CLI interface is by the way:
😍 |
Co-authored-by: Romain Ruetschi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments on things I missed in my first pass.
@romac cool, thanks; glad you like it :) What I particularly like about |
@shonfeder @romac @brapse I think I've addressed all the issues raised in your reviews; thank you, that was very helpful, and allowed to improve the code a lot:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
decided to make `round` an explicit parameter when constructing the commit. The reason for this is that we want to allow generating votes only from the header, but without explicitely given round, the generated votes will point to the default 1. Setting the `round` afterwards in the Commit struct will have no effect on those votes. That's why `round` is now an explicit parameter, and there are two constructors: `new()`, and `new_with_votes()`.
Btw, the failing |
Here we introduce both the code-level helpers for generating tendermint object hierarchies in tests, as well as the command-line generator of those hierarchies.
For the high-level explanation please see #393.
This is still a WIP, but as it is already usable it probably makes sense to merge now, and then extend in separate PRs/issues.
Will be grateful for your reviews!