-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive Hash
on tendermint::Time
#1054
Conversation
Now that we're backed by a data structure with unambiguously unique values, we can make time moments hashable.
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
========================================
- Coverage 62.5% 62.4% -0.2%
========================================
Files 236 236
Lines 21321 21342 +21
========================================
- Hits 13331 13319 -12
- Misses 7990 8023 +33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Nice! Ready to merge this, or is there more you want to do here? |
Oh, let me dress it up with a changelog entry :) |
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Mikhail Zabaluev <[email protected]>
Now that we're backed by a data structure with unambiguously unique values, we can make time moments hashable.
Updated all relevant documentation in docsUpdated all code comments where relevant.changelog/