-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrustThresholdFraction
: allow to be initialized with value 1
#1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we should follow what the Go implementation does here.
Fix the docs and it should be good to go.
The rustdoc problem should have been fixed in #1212, so merge/rebase to get rid of it.
tendermint/src/trust_threshold.rs
Outdated
@@ -54,7 +54,7 @@ impl TrustThresholdFraction { | |||
/// The parameters are valid iff `1/3 <= numerator/denominator < 1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc needs to be updated too, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
=======================================
- Coverage 64.0% 63.9% -0.1%
=======================================
Files 253 253
Lines 21636 21636
=======================================
- Hits 13851 13839 -12
- Misses 7785 7797 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closes: #1208
.changelog/