Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization refactor step 2 #257

Closed
wants to merge 6 commits into from
Closed

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented May 7, 2020

Implemented null-value deserialization for Vec<u8> using Visitor.

This is part 2 of the serialization improvement efforts described in #247 .

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@greg-szabo greg-szabo changed the title Greg/serialization 2 Serialization refactor step 2 May 7, 2020
@greg-szabo greg-szabo mentioned this pull request May 8, 2020
5 tasks
@greg-szabo greg-szabo changed the base branch from greg/serialization-1 to master May 9, 2020 20:11
@greg-szabo greg-szabo mentioned this pull request May 13, 2020
5 tasks
@greg-szabo
Copy link
Member Author

i'm closing this in lieu of #269 . After merging step 1, it was easier to cherry-pick the working commits from this branch into a new one and open a new PR with that.

@greg-szabo greg-szabo closed this May 13, 2020
@greg-szabo greg-szabo deleted the greg/serialization-2 branch May 13, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant