Updated tests using testgen #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
greg-szabo
commented
Oct 7, 2020
greg-szabo
commented
- Referenced an issue explaining the need for the change
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
greg-szabo
commented
Oct 7, 2020
light-client/tests/support/model_based/single_step/MC4_4_faulty_TestHeaderFromFuture.json
Show resolved
Hide resolved
ebuchman
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Removed amino traits, block, signature, vote * tendermint: Fix header hashing This commit fixes the header hashing mechanism to match that of the current Go version. It also adds a test to ensure the happy path works. Signed-off-by: Thane Thomson <[email protected]> * light-client: Resolve #600 Demonstrates that the previous commit (fixing the header hash) fixes #600 when executed against a running Tendermint node. Signed-off-by: Thane Thomson <[email protected]> * tendermint: Use shorthand form of method call Signed-off-by: Thane Thomson <[email protected]> * tendermint: Add header hash check in integration test Signed-off-by: Thane Thomson <[email protected]> * tendermint: Add workaround for empty BlockId Prost seems to encode an empty raw protobuf BlockId as an empty vector of bytes, whereas the Go encoder encodes the same object to [18, 0]. This commit adds a workaround to demonstrate that this is the case when testing against Tendermint v0.34 (otherwise header hashing would fail). Signed-off-by: Thane Thomson <[email protected]> * rpc: Update integration test fixture It seems as though the previous commit data was generated by an older version of Tendermint. The new commit fixtures here are generated by Tendermint 0.34.0-99aea7b0 running in a Docker container on my local machine. Signed-off-by: Thane Thomson <[email protected]> * Added Proposal domain type with signing - tests fail for now * tendermint: Make last_block_id encoding workaround more explicit Signed-off-by: Thane Thomson <[email protected]> * tendermint: Fix empty last_block_id encoding issue Signed-off-by: Thane Thomson <[email protected]> * Proposal and Vote signable bytes functions * PubKeyResponse made into PublicKey * Header.Hash() fixes * Merge conflict fixes * Proposal test fixes * Updated CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md * regenerate static model-based files * Update tendermint/Cargo.toml * Remvoed amino bech32 encoding * Updated priv_validator.json test with non-amino public key result * Removed comments referencing amino. * Review fixes #1 * Review fixes #2 * Review fixes #3 * Updated tests using testgen (#615) * Update tendermint/src/public_key.rs Co-authored-by: Tomas Tauber <[email protected]> * fmt fix * Fixes number four, additional derive traits Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Andrey Kuprianov <[email protected]> Co-authored-by: Tomas Tauber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.