Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove total_voting_power parameter from validator::Set::new #740

Merged
merged 6 commits into from
Dec 15, 2020
Merged

Remove total_voting_power parameter from validator::Set::new #740

merged 6 commits into from
Dec 15, 2020

Conversation

romac
Copy link
Member

@romac romac commented Dec 14, 2020 •
edited
Loading

Close #739

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac requested a review from thanethomson December 14, 2020 17:35
thanethomson
thanethomson reviewed Dec 15, 2020
View reviewed changes
tendermint/src/validator.rs Outdated
))

Ok(Self {
validators: unsorted_validators_result?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer sorts the validator set (which is done in Set::new()) - is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch! Will fix this right now

@romac romac requested a review from thanethomson December 15, 2020 16:11
thanethomson
thanethomson approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thanethomson thanethomson merged commit 4225d7f into master Dec 15, 2020
@thanethomson thanethomson deleted the romac/remove-total-voting-power-param branch December 15, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove total_voting_power parameter from validator::Set::new
2 participants
@romac @thanethomson