Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fails to compile with signatory 0.16 #82

Closed

Conversation

linfeng-crypto
Copy link

solution: update signature to version 0.16 and use signature crate 1.0.0-pre.1

tarcieri
tarcieri previously approved these changes Dec 2, 2019
@liamsi
Copy link
Member

liamsi commented Dec 2, 2019

Could you re-commit with a GPG signed commit and force push? Otherwise we can't merge currently.

solution: Update signature to version 0.16 and use signature crate 1.0.0-pre.1
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi
Copy link
Member

liamsi commented Dec 10, 2019

Since recently this started failing with:

  Compiling ed25519-dalek v1.0.0-pre.3
error[E0432]: unresolved import `rand`
  --> /Users/ismail/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/ed25519-dalek-1.0.0-pre.3/src/ed25519.rs:14:5
   |
14 | use rand::{CryptoRng, RngCore};
   |     ^^^^ use of undeclared type or module `rand`

error[E0432]: unresolved import `rand`
  --> /Users/ismail/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/ed25519-dalek-1.0.0-pre.3/src/secret.rs:22:5
   |
22 | use rand::{CryptoRng, RngCore};
   |     ^^^^ use of undeclared type or module `rand`

error: aborting due to 2 previous errors

This is unrelated to the changes made here. I ran into the same issue in #63 (comment)
I would still hold off merging this until we resolved the issue that causes this.

@tarcieri
Copy link
Contributor

Looks like it's due to an upstream release of ed25519-dalek. I would guess that including it in Cargo.toml with the rand feature enabled would fix it (or locking to the previous prerelease).

@liamsi
Copy link
Member

liamsi commented Dec 10, 2019

Thanks @tarcieri! That works! I'll fix master in a bit and then merge in this PR.

@liamsi
Copy link
Member

liamsi commented Dec 10, 2019

Just for my understanding. This is due to the rand feature which used to be a default feature and is not anymore?

@tarcieri
Copy link
Contributor

tarcieri commented Dec 10, 2019

I think it's an upstream regression. I'll try to investigate and open an issue.

@tarcieri
Copy link
Contributor

@linfeng-crypto can you rebase?

@liamsi
Copy link
Member

liamsi commented Dec 11, 2019

Superseded by #89

@liamsi liamsi closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants