-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce RPC query parsing #949
Conversation
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
========================================
+ Coverage 71.6% 71.9% +0.2%
========================================
Files 203 203
Lines 16277 16550 +273
========================================
+ Hits 11669 11911 +242
- Misses 4608 4639 +31
Continue to review full report at Codecov.
|
Tested the subscribe with NewBlock events and seems to work correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
✔️ 👛 🎿 ⛰
Signed-off-by: Thane Thomson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ ⏫ 🍽 💢
Closes #859
rust-peg
had a release in April that solved some of the original issues we had with this. This PR is mostly just a copy/paste from #858..changelog/