Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print options slide toggle #189

Closed
cbourget opened this issue Sep 27, 2018 · 2 comments
Closed

Print options slide toggle #189

cbourget opened this issue Sep 27, 2018 · 2 comments
Assignees
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations

Comments

@cbourget
Copy link
Collaborator

Please tell us about your environment:

69.0.3497.92

  • Igo Version:
    latest

  • Node:

10.9.0

According to this: https://material.io/design/components/selection-controls.html#switches

I think using slide toggles instead of checkboxes would be the preferred way to toggle the projection, scale and legend in the print tool.

The checkboxes don't feel particularly wrong so we could stick with them too.

@cbourget cbourget added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Sep 27, 2018
@cbourget
Copy link
Collaborator Author

On a similar topic, I think the radio buttons to select the orientation should be replaced with a select field like we have in most browsers print tool.

@cbourget
Copy link
Collaborator Author

Overall, it would look like this mockup.

igo2-print-form-mockup

@ameliebernier ameliebernier self-assigned this Nov 16, 2018
ameliebernier added a commit that referenced this issue Nov 23, 2018
ameliebernier added a commit that referenced this issue Nov 23, 2018
ameliebernier added a commit that referenced this issue Nov 26, 2018
mbarbeau pushed a commit that referenced this issue Dec 6, 2018
* Issue #189 Print options fix

* Issue #189 Removed alert

* Issue #189 Ajusted margins

* Removed '!important' and unused modules
@mbarbeau mbarbeau closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations
Projects
None yet
Development

No branches or pull requests

3 participants