Message translation on language change #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PhilippeLafreniere18 reported to 1.13... too much changes |
pelord
added
the
to test
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* feat(language): provide an observable to monitor language change * feat(message): translate message (ngx-toastr) while shown * refactor(messageservice): allow interpolate param on language change. * Update message.service.ts * refactor(messageservice): allow interpolate param on language change. * lint * lint Co-authored-by: Pierre-Étienne Lord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
If the app language is changed... there is no method to translated active message
What is the new behavior?
1- Add a method to translate dynamically the active message
2- observable for language change
3- TODO pass to messageService a key/interpolation params instead of a translated message.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: