Img preview #1118
Merged
Img preview #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 28, 2022 17:22
…avoid message service to raise
…avoid message service to raise
PhilippeLafreniere18
approved these changes
Nov 3, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* fix(secureImage): handle missing image to show unavailable image and avoid message service to raise * lint + cleanup * fix(secureImage): handle missing image to show unavailable image and avoid message service to raise * lint * chore(build): remove reverse storedqueries from default build (prod and dev) * chore(build): remove reverse storedqueries from default build (prod and dev) * fix(demo): fix layer error * refactor(layer-legend): legend was flashing during loading Co-authored-by: Pierre-Étienne Lord <[email protected]> Co-authored-by: Philippe Lafreniere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Missing image cause error to be raised (toast).
What is the new behavior?
Create a new directive to catch image error and show and alternate image (or not)
Directive name: igoImageError
input1 (optionnal) = errorImageUrl (default = '/assets/igo2/common/images/na.png';)
input2 (optionnal) = hideError (default = false) If true, no alternate image is shown. The image is hidden by css
check the entity-table demo to validate the directive.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: