Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1632 la modale dauthentification le bouton se connecter et rester anonyme #1633

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Feb 9, 2024

Fix #1632

Go to the issue to see more details and example of the new design proposition

- feat(auth): add the capability to theme the auth package
@alecarn alecarn requested a review from pelord February 9, 2024 15:04
@alecarn alecarn self-assigned this Feb 9, 2024
@alecarn alecarn changed the base branch from master to next February 9, 2024 15:04
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le spinner apparait tellement rapidement.. est-il vraiment nécessaire! Mais tout est beau

@alecarn
Copy link
Collaborator Author

alecarn commented Feb 14, 2024

Le spinner apparait tellement rapidement.. est-il vraiment nécessaire! Mais tout est beau

C'est pour indiquer qu'il y a l'état de progression et de bloquer les boutons en ajoutant un splashscreen... Ce n'est pas parfait mais un peu mieux.

@alecarn alecarn merged commit 229989d into next Feb 14, 2024
4 checks passed
@alecarn alecarn deleted the 1632-la-modale-dauthentification-le-bouton-se-connecter-et-rester-anonyme branch February 14, 2024 14:42
@alecarn
Copy link
Collaborator Author

alecarn commented Aug 22, 2024

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

La modale d'authentification, le bouton se "Connecter" et "Rester anonyme"
2 participants