Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity table): connect entity tables to the state view #497

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

cbourget
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Entity tables use the store's view, which can be a limitation when trying to do things like showing selected entities only.

What is the new behavior?
Entity tables use the stateView. Also, entity tables are optimized to not rerender themselves completely.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@cbourget cbourget force-pushed the entity-table-state-view branch from 826759c to 9a6e7b9 Compare October 31, 2019 19:31
@cbourget cbourget force-pushed the entity-table-state-view branch from 9a6e7b9 to 38efba8 Compare November 1, 2019 14:17
@mbarbeau mbarbeau merged commit 1d8252b into master Nov 5, 2019
@mbarbeau mbarbeau deleted the entity-table-state-view branch November 5, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants