Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular version issues #113

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Angular version issues #113

merged 2 commits into from
Feb 17, 2017

Conversation

cbourget
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

  • Issues with search services that use JSONP
  • Issues with material directives that use the camelCase syntax in the latest version ua material

What is the new behavior?

  • None of these issues by staying at stable versions of angular and matrial

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Other information:
The change in search-tool.component.html should not be in that commit but it accidently got here so, live with it ;)

@mbarbeau mbarbeau merged commit dbe11ae into master Feb 17, 2017
@mbarbeau mbarbeau deleted the angular-version-issues branch February 17, 2017 14:20
cbourget added a commit that referenced this pull request Feb 17, 2017
* bug(highlight selected result): Fix typo that responsible of the loss of the selected result

* fix(jsonp and material issues): Stay at stables angular and angular material versions
cbourget added a commit that referenced this pull request Feb 17, 2017
* bug(highlight selected result): Fix typo that responsible of the loss of the selected result

* fix(jsonp and material issues): Stay at stables angular and angular material versions
matrottier pushed a commit that referenced this pull request Nov 17, 2021
* This suscribe was not referencing to named id

This suscribe was not using the named id as defined into the context.json

* lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants