Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(menu-button): change menu button component to library #667

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

PhilippeLafreniere18
Copy link
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

  • Menu button style do not display correctly since release 1.9.0 due to theming breaking change

What is the new behavior?

  • Menu button component is now implemented in igo2-lib to allow the actual theming structure to display button style correctly

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@PhilippeLafreniere18 PhilippeLafreniere18 merged commit 1f77d0a into next Sep 29, 2021
pelord added a commit that referenced this pull request Oct 12, 2021
* Feat(docs): ogc filter time add example and new param (#660)

* add example and new param calendarModeYear

* doc

* doc

* doc

* doc

* doc

* docs

* doc

* criss de doc

* grrrr

* doc fuck

* calisse

* feat(docs) add wms-wfs combinés

* lint

* doc

Co-authored-by: Philippe Lafreniere <[email protected]>

* refactor(menu-button): change menu button component to library (#667)

* WIP: fix menu button reverse color fix

* refactor(portal): menu button component to igo2-lib

* refactor(portal): handling of url controls for directions tool.

Co-authored-by: josee666 <[email protected]>
Co-authored-by: Philippe Lafreniere <[email protected]>
Co-authored-by: Philippe Lafrenière <[email protected]>
pelord added a commit that referenced this pull request Oct 13, 2021
* Feat(docs): ogc filter time add example and new param (#660)

* add example and new param calendarModeYear

* feat(docs) add wms-wfs combinés

* refactor(menu-button): change menu button component to library (#667)

* WIP: fix menu button reverse color fix

* refactor(portal): menu button component to igo2-lib

* Fix(portal)  toast panel html display (#669)

* fix temp(portal) html display

* fix(portal) html display with no error

* refactor(portal): handling of url controls for directions tool. (#675)

* feat(sharemap): keep the layer wms version on share map (#671)

* feat(sharemap): keep the layer wms version on share map

* add windows script equivalent

* fix tar zip command

* paakge scripts: replace version.win

* chore(package): delete ghrelease, crash based on publish-release

* chore(deps): update to igo2-lib 1.9.1

* 1.9.1

Co-authored-by: josee666 <[email protected]>
Co-authored-by: Philippe Lafreniere <[email protected]>
Co-authored-by: Philippe Lafrenière <[email protected]>
@pelord pelord deleted the menuReverseColorFix branch November 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant