Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url with version on share map link #837

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

hugbe8
Copy link
Member

@hugbe8 hugbe8 commented Oct 6, 2022

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
On use of the map sharing tool a layer coming from a service with specific version does not retrieve the associated options via "OptionsApiService" when retrieving the link. The reason is that the recovery code does not remove the '?' character (add in the url to register the version) for to make the match with the "OptionsApiService" service and the match is not done.

What is the new behavior?
Layer matching is now possible via the "OptionsApiService" service with a wms using a specific version other than the default one

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@hugbe8 hugbe8 added bug Incorrect or unexpected behaviors // Anomalies de fonctionnement and removed bug Incorrect or unexpected behaviors // Anomalies de fonctionnement labels Oct 6, 2022
@pelord pelord merged commit 294c645 into next Oct 24, 2022
@pelord pelord deleted the ulrWithVersion_onShare branch October 24, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants