Merge pull request #140 from ing-bank/remove_sample_ropw

Remove sample_row from probatus
ing-bank · Apr 21, 2021 · 8de5705 · 8de5705
2 parents 6bf1241 + 3df8b6a
commit 8de5705
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 310 deletions.
diff --git a/docs/api/utils.md b/docs/api/utils.md
@@ -3,5 +3,3 @@
 This module contains various smaller functionalities that can be used across the `probatus` package.
 
 ::: probatus.utils.scoring
-
-::: probatus.utils.sampling
diff --git a/probatus/utils/__init__.py b/probatus/utils/__init__.py
@@ -35,7 +35,6 @@
     assure_list_of_strings,
     assure_list_values_allowed,
 )
-from .sampling import sample_row
 from .plots import plot_distributions_of_feature
 from .interface import BaseFitComputeClass, BaseFitComputePlotClass
 
@@ -59,7 +58,6 @@
     "shap_to_df",
     "calculate_shap_importance",
     "assure_pandas_series",
-    "sample_row",
     "preprocess_data",
     "preprocess_labels",
     "BaseFitComputeClass",

diff --git a/probatus/utils/sampling.py b/probatus/utils/sampling.py
diff --git a/tests/docs/test_docstring.py b/tests/docs/test_docstring.py
@@ -14,6 +14,8 @@
 import probatus.utils
 import probatus.missing_values
 
+from typing import List
+
 # Turn off interactive mode in plots
 plt.ioff()
 matplotlib.use("Agg")
@@ -41,9 +43,7 @@
     probatus.feature_elimination.EarlyStoppingShapRFECV,
 ]
 
-FUNCTIONS_TO_TEST = [
-    probatus.utils.sample_row,
-]
+FUNCTIONS_TO_TEST: List = []
 
 
 def handle_docstring(doc, indent):

diff --git a/tests/utils/test_sampling.py b/tests/utils/test_sampling.py
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,5 +3,3 @@
		This module contains various smaller functionalities that can be used across the `probatus` package.

		::: probatus.utils.scoring

		::: probatus.utils.sampling