Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed to explainer + remove np.random.state() #255

Closed
Tracked by #252
ReinierKoops opened this issue Mar 26, 2024 · 1 comment
Closed
Tracked by #252

Add seed to explainer + remove np.random.state() #255

ReinierKoops opened this issue Mar 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ReinierKoops
Copy link

Problem Description
Currently we have a np.random.seed state set in the code somewhere. Now that SHAP has the ability to set seed for its tree explainers, we can remove that code and add the seed directly to SHAP explainer.

Desired Outcome
Do the problem described above.

Solution Outline
Remove it and add random state reference as seed to explainers.

@ReinierKoops
Copy link
Author

fixed in PR #252

ReinierKoops pushed a commit that referenced this issue Apr 23, 2024
…252)

This PR depends on the PR to be accepted:
#248

______

This cleanup removes some more unused code and simplifies parts of our
implementations. It should allow for a boost in performance for bigger
use-cases, although minimal.

Also fix:

- [x] #242 comments 
- [x] #255
- [x] #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant