Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action that will run unit tests everyday, closes #42 #113

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

timvink
Copy link
Contributor

@timvink timvink commented Mar 26, 2021

No description provided.

@timvink
Copy link
Contributor Author

timvink commented Mar 26, 2021

@Matgrb unit tests fail, but this cannot be related to this PR. Could already be a case of an incompatible downstream dependency update? Which is exactly the kind of situation this PR is meant to make us aware of.

@Matgrb
Copy link
Contributor

Matgrb commented Mar 26, 2021

I think this might be the case.
I will investigate this and fix it.

@Matgrb
Copy link
Contributor

Matgrb commented Mar 26, 2021

Found the issue.

It was unit tests that used to mock figure, in order to make sure that it does not show up when running the tests.
The easy solution was to use the parameter show=False in all tests that use plot()

@Matgrb Matgrb merged commit d483011 into main Mar 26, 2021
@ReinierKoops ReinierKoops deleted the cronjob_test_dependencies branch December 5, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants