Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use "Grouped" CV instances from scikit-learn #182

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

PaulZhutovsky
Copy link
Contributor

closes #181

Allows the usage of Group CV objects in ShapRFECV.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PaulZhutovsky
Copy link
Contributor Author

The tests fail but the reason seems to be that pip is not able to resolve the dependencies under Python 3.7 which was mentioned by @operte.

@timvink
Copy link
Contributor

timvink commented Apr 19, 2022

The related issue is #185

@operte
Copy link
Contributor

operte commented Apr 21, 2022

The failed checks are not related to this PR, so I will merge it.

@operte operte merged commit f409c8e into ing-bank:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for group-based cross-validation objects from scikit-learn
4 participants