Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement verbose to ShapRSECV #22

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Implement verbose to ShapRSECV #22

merged 2 commits into from
Nov 24, 2020

Conversation

Matgrb
Copy link
Contributor

@Matgrb Matgrb commented Nov 20, 2020

#21

@Matgrb Matgrb requested a review from timvink November 20, 2020 16:10
timvink
timvink reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@timvink timvink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks, feel free to merge already

probatus/feature_elimination/feature_elimination.py Show resolved Hide resolved
probatus/feature_elimination/feature_elimination.py Show resolved Hide resolved
tests/feature_elimination/test_feature_elimination.py Outdated Show resolved Hide resolved
@Matgrb Matgrb merged commit 2e5119c into main Nov 24, 2020
@Matgrb Matgrb deleted the 21-verbose branch November 24, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvink timvink timvink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matgrb @timvink