Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support any classifier extending basesearchcv #89

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Support any classifier extending basesearchcv #89

merged 5 commits into from
Mar 9, 2021

Conversation

Matgrb
Copy link
Contributor

@Matgrb Matgrb commented Mar 8, 2021

Closes #76
Closes #49

@Matgrb Matgrb force-pushed the support_search_cv branch from ec9deb3 to 3442920 Compare March 8, 2021 16:27
@Matgrb Matgrb requested a review from timvink March 8, 2021 16:29
timvink
timvink suggested changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@timvink timvink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Not quite there yet though:

I recommend just doing a quick search of GridSearchCV and make sure every mention is OK.

@Matgrb
Copy link
Contributor Author

Matgrb commented Mar 9, 2021

@timvink Could you have a look again?

@timvink timvink merged commit e09e1c6 into main Mar 9, 2021
@Matgrb Matgrb deleted the support_search_cv branch March 10, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvink timvink timvink requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Matgrb @timvink