Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingk 1017 create wrapper of lptypes get adapters info #298

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

julieta-prieto
Copy link

@julieta-prieto julieta-prieto commented Feb 5, 2025

Description

Cython wrapper for GetAdaptersInfo

To build the wrapper:

ingeniamotion/cy_wrappers/get_adapters_info
python setup.py build_ext --inplace

It substitutes previous wmi implementation.

Type of change

Please add a description and delete options that are not relevant.

  • Replace wmi check with cython wrapper get_adapters_info()

Tests

  • Connected to PC without admin rights where wmi import failed, and the wrapper succeeded to retrieve the adapters information.

Documentation

Please update the documentation.

  • Update docstrings of every function, method or class that change.
  • USe type hints for every function and argument.
  • Build documentation locally to verify changes.
  • Add the changes at the [Unreleased] section of the CHANGELOG.

Code formatting

  • Use the ruff package to format the code: ruff format ingeniamotion tests.
  • Use the ruff package to lint the code: ruff check ingeniamotion tests.

Others

  • ⚠️ still missing cython integration with the module to make it fully functional

@julieta-prieto julieta-prieto marked this pull request as ready for review February 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant