suggestion(YouTube Music): Rename Enable black navigation bar & Enable black player background to Change navigation bar color & Change player background color respectively

[ILoveOpenSourceApplications]

Application

YouTube Music

Suggestion description

Currently, when a user selects Dark theme, it is applied to certain UI elements that are Grey in stock YT Music, except for the navigation bar which relies on the user selecting Navigation bar components to change its theme.

Instead, I would like to have the Dark theme patch to control the theme of whatever UI element that gets changed instead of relying on a separate patch, if possible.

Acknowledgements

• This issue is not a duplicate of an existing suggestion.
• This is not a feature request.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

It already works as intended in revanced-patches-5.2.1

1. Patch Dark Theme included (Dark theme background color: Catppuccin (Mocha), MaterialYou: off), turn off Enable black navigation bar
   : Navigation bar color is Catppuccin (Mocha)

2. Patch Dark Theme excluded, turn off Enable black navigation bar
   : Navigation bar color is YouTube Music Grey

[ILoveOpenSourceApplications]

Is there a dependency for Navigation bar components patch?

[inotia00]

Nah.. those two patches work independently

If the title of this issue was 'Change Enable black navigation bar setting to Change navigation bar color setting', then it would be a valid issue

[ILoveOpenSourceApplications]

Why I'm asking is I just tried patching without it and still I'm seeing the option in RVX settings

[ILoveOpenSourceApplications]

Screenshots

[ILoveOpenSourceApplications]

Hide ads, if selected, will automatically include Navigation bar components. Noted.

But yes, if Dark theme is included and Enable black navigation bar is off, then it will change the theme of the navigation bar to whatever color selected (default being AMOLED black). Then why give that option? I'm pretty sure those including the theme are the ones who want to change it and those who don't won't care for that option.

Isn't it better to remove it?

[ILoveOpenSourceApplications]

Also, slightly off topic, but with YouTube Music, you've included MaterialYou within Dark theme patch. Why not do the same about YouTube and add it to Theme patch as well?

[ILoveOpenSourceApplications]

Also also, was this behavior always like this?

1. Patch Dark Theme included (Dark theme background color: Catppuccin (Mocha), MaterialYou: off), turn off Enable black navigation bar
   : Navigation bar color is Catppuccin (Mocha)

Or was it changed with the recent Dark theme patch? Cause I remember at some point when I turned off Enable black navigation bar with Amoled included, the navigation bar changed to Grey color.

[inotia00]

Nah.. those two patches work independently

This means that the Dark theme patch and the Navigation bar components patch are independent of each other

The Navigation bar components patch is not independent of the Hide ads patch

(If the Hide ads patch is included, the Navigation bar components patch is also included - to remove the Upgrade button in the navigation bar)

[inotia00]

Also, slightly off topic, but with YouTube Music, you've included MaterialYou within Dark theme patch. Why not do the same about YouTube and add it to Theme patch as well?

The Theme patch and the MaterialYou patch on YouTube work a little differently, making them hard to integrate

(This is also mentioned in the wiki)

Conditions

• Theme patch included (darkThemeBackgroundColor: Amoled Black, lightThemeBackgroundColor: White)
• MaterialYou patch included

Results

• Dark theme background color for Android 12+: Amoled Dark
• Light theme background color for Android 12+: Monet White
• Dark theme background color for Android 11: Amoled Black
• Light theme background color for Android 11: White

Conditions

• Theme patch excluded
• MaterialYou patch included

Results

• Dark theme background color for Android 12+: Monet Dark
• Light theme background color for Android 12+: Monet White
• Dark theme for Android 11 Background color: YouTube Dark
• Light theme background color for Android 11: YouTube Light

[inotia00]

But yes, if Dark theme is included and Enable black navigation bar is off, then it will change the theme of the navigation bar to whatever color selected (default being AMOLED black). Then why give that option? I'm pretty sure those including the theme are the ones who want to change it and those who don't won't care for that option.

Isn't it better to remove it?

As the Enable black player background setting remains, there seems to be no need to remove the Enable black navigation bar setting

If the title of this issue was 'Change Enable black navigation bar setting to Change navigation bar color setting', then it would be a valid issue

This suggestion is valid, as it extends the Enable black navigation bar setting

[ILoveOpenSourceApplications]

Apologies for asking a lot of questions here, but I'm simply trying to get a clarity of the situation 😅.

Naming can be improved. If you're planning to keep the patch then sure something like Change navigation bar color to black or simply Change color to black would be better than the current one given the option is already within Navigation bar in Settings page.

But can you answer this one as well #2647 (comment)?

[inotia00]

Also also, was this behavior always like this?

1. Patch Dark Theme included (Dark theme background color: Catppuccin (Mocha), MaterialYou: off), turn off Enable black navigation bar
   : Navigation bar color is Catppuccin (Mocha)

Or was it changed with the recent Dark theme patch? Cause I remember at some point when I turned off Enable black navigation bar with Amoled included, the navigation bar changed to Grey color.

Yes

[ILoveOpenSourceApplications]

1. Yes, as in it was like that.
   Or
2. Yes, as in it was changed to be like that recently.

[inotia00]

it was changed to be like that recently

[ILoveOpenSourceApplications]

Sorry for all the bother. I have changed the issue title according to your suggestions. Have a great day!.