bug(YouTube - Overlay Buttons): When the patch option Bottom margin is 0, all player bottom buttons are hidden

[GucekPL]

Type

Error at runtime

Tools used

RVX Manager

Application

App version: 19.44.39
Patches version: 5.3.1-dev.4

Bug description

When I enter any video, all buttons just above the seekbar do not appear - more precisely: timestamp, additional info to them, any overlay button, fullscreen button. Naturally, I didn't touched any of these options after install. "Widoczny/widoczne" means "shown", "ukryty/ukryte" means "hidden".

Error logs

Solution

No response

Additional context

No response

Device Environment

Phone: POCO X6 Pro 5G
Android: 15
System version: 2.0.2.0.VNLEUXM (EEA Region)

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I did not use any settings marked as Experimental Flags.
• I have patched the APK according to the documentation.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

Does the issue still occur even if you exclude the Overlay buttons patch?

Also, have you changed any patch options for the Overlay buttons patch?

[GucekPL]

@inotia00 I didn't change any patches options in Overlay buttons patch, all same as always I'm patching. And issue don't occur after excluding patch, so Overlay buttons is causing issue.

[inotia00]

It may be due to the recently merged PR inotia00/revanced-patches#129

There was no issue when I tested it on my device, but I didn't know there was an issue on other devices.

I'll revert the PR.

[anddea]

What options have you modified within the Overlay buttons patch? Could you please share the values you've set for bottomMargin and widerButtonsSpace? Also, could you reset the manager and the YouTube app to their default settings and check if the issue persists?

[GucekPL]

That's my settings and issue persists on fresh installation.

[anddea]

Yep, as I thought. Reverting the commit is not necessary. The problem stems from the bottom margin being set to 0dip. Fixing this (bottom margin) should resolve the issue; apart from that, it functions correctly.

[inotia00]

Reflected in revanced-patches-5.3.1