Skip to content

Commit

Permalink
refactor(elements|ino-sidebar): remove component (#669)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Since the component is just a container with a simple slide animation and does not provide any other functionality or styling, we decided to remove it.
  • Loading branch information
MariaLStefan authored Oct 4, 2022
1 parent 73dfc9a commit 349b84d
Show file tree
Hide file tree
Showing 19 changed files with 0 additions and 772 deletions.
5 changes: 0 additions & 5 deletions .github/semantic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ scopes:
- elements|ino-segment-button
- elements|ino-segment-group
- elements|ino-select
- elements|ino-sidebar
- elements|ino-snackbar
- elements|ino-spinner
- elements|ino-switch
Expand Down Expand Up @@ -104,7 +103,6 @@ scopes:
- elements-angular|ino-segment-button
- elements-angular|ino-segment-group
- elements-angular|ino-select
- elements-angular|ino-sidebar
- elements-angular|ino-snackbar
- elements-angular|ino-spinner
- elements-angular|ino-switch
Expand Down Expand Up @@ -155,7 +153,6 @@ scopes:
- elements-react|ino-segment-button
- elements-react|ino-segment-group
- elements-react|ino-select
- elements-react|ino-sidebar
- elements-react|ino-snackbar
- elements-react|ino-spinner
- elements-react|ino-switch
Expand Down Expand Up @@ -206,7 +203,6 @@ scopes:
- elements-vue|ino-segment-button
- elements-vue|ino-segment-group
- elements-vue|ino-select
- elements-vue|ino-sidebar
- elements-vue|ino-snackbar
- elements-vue|ino-spinner
- elements-vue|ino-switch
Expand Down Expand Up @@ -257,7 +253,6 @@ scopes:
- storybook|ino-segment-button
- storybook|ino-segment-group
- storybook|ino-select
- storybook|ino-sidebar
- storybook|ino-snackbar
- storybook|ino-spinner
- storybook|ino-switch
Expand Down
5 changes: 0 additions & 5 deletions commit-scope-enum.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ module.exports = [
'elements|ino-segment-button',
'elements|ino-segment-group',
'elements|ino-select',
'elements|ino-sidebar',
'elements|ino-snackbar',
'elements|ino-spinner',
'elements|ino-switch',
Expand Down Expand Up @@ -88,7 +87,6 @@ module.exports = [
'elements-angular|ino-segment-button',
'elements-angular|ino-segment-group',
'elements-angular|ino-select',
'elements-angular|ino-sidebar',
'elements-angular|ino-snackbar',
'elements-angular|ino-spinner',
'elements-angular|ino-switch',
Expand Down Expand Up @@ -138,7 +136,6 @@ module.exports = [
'elements-react|ino-segment-button',
'elements-react|ino-segment-group',
'elements-react|ino-select',
'elements-react|ino-sidebar',
'elements-react|ino-snackbar',
'elements-react|ino-spinner',
'elements-react|ino-switch',
Expand Down Expand Up @@ -188,7 +185,6 @@ module.exports = [
'elements-vue|ino-segment-button',
'elements-vue|ino-segment-group',
'elements-vue|ino-select',
'elements-vue|ino-sidebar',
'elements-vue|ino-snackbar',
'elements-vue|ino-spinner',
'elements-vue|ino-switch',
Expand Down Expand Up @@ -238,7 +234,6 @@ module.exports = [
'storybook|ino-segment-button',
'storybook|ino-segment-group',
'storybook|ino-select',
'storybook|ino-sidebar',
'storybook|ino-snackbar',
'storybook|ino-spinner',
'storybook|ino-switch',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ export const DIRECTIVES = [
d.InoSegmentButton,
d.InoSegmentGroup,
d.InoSelect,
d.InoSidebar,
d.InoSnackbar,
d.InoSpinner,
d.InoSwitch,
Expand Down
28 changes: 0 additions & 28 deletions packages/elements-angular/elements/src/directives/proxies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1046,34 +1046,6 @@ export class InoSelect {
}


export declare interface InoSidebar extends Components.InoSidebar {
/**
* Emits an event if the user expands or collapses the sidebar
*/
openChange: EventEmitter<CustomEvent<any>>;

}

@ProxyCmp({
defineCustomElementFn: undefined,
inputs: ['alignRight', 'name', 'open']
})
@Component({
selector: 'ino-sidebar',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
inputs: ['alignRight', 'name', 'open']
})
export class InoSidebar {
protected el: HTMLElement;
constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) {
c.detach();
this.el = r.nativeElement;
proxyOutputs(this, this.el, ['openChange']);
}
}


export declare interface InoSnackbar extends Components.InoSnackbar {
/**
* Event that emits as soon as the action button is clicked.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export {
InoTooltip,
InoOption,
InoDialog,
InoSidebar,
InoNavItem,
InoNavDrawer,
InoHeader
Expand Down
1 change: 0 additions & 1 deletion packages/elements-react/src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export const InoRange = /*@__PURE__*/createReactComponent<JSX.InoRange, HTMLInoR
export const InoSegmentButton = /*@__PURE__*/createReactComponent<JSX.InoSegmentButton, HTMLInoSegmentButtonElement>('ino-segment-button');
export const InoSegmentGroup = /*@__PURE__*/createReactComponent<JSX.InoSegmentGroup, HTMLInoSegmentGroupElement>('ino-segment-group');
export const InoSelect = /*@__PURE__*/createReactComponent<JSX.InoSelect, HTMLInoSelectElement>('ino-select');
export const InoSidebar = /*@__PURE__*/createReactComponent<JSX.InoSidebar, HTMLInoSidebarElement>('ino-sidebar');
export const InoSnackbar = /*@__PURE__*/createReactComponent<JSX.InoSnackbar, HTMLInoSnackbarElement>('ino-snackbar');
export const InoSpinner = /*@__PURE__*/createReactComponent<JSX.InoSpinner, HTMLInoSpinnerElement>('ino-spinner');
export const InoSwitch = /*@__PURE__*/createReactComponent<JSX.InoSwitch, HTMLInoSwitchElement>('ino-switch');
Expand Down
8 changes: 0 additions & 8 deletions packages/elements-vue/src/proxies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -444,14 +444,6 @@ export const InoSelect = /*@__PURE__*/ defineContainer<JSX.InoSelect>('ino-selec
'value', 'v-value-change', 'valueChange');


export const InoSidebar = /*@__PURE__*/ defineContainer<JSX.InoSidebar>('ino-sidebar', undefined, [
'alignRight',
'open',
'name',
'openChange'
]);


export const InoSnackbar = /*@__PURE__*/ defineContainer<JSX.InoSnackbar>('ino-snackbar', undefined, [
'message',
'actionText',
Expand Down
45 changes: 0 additions & 45 deletions packages/elements/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1085,20 +1085,6 @@ export namespace Components {
*/
"value"?: string;
}
interface InoSidebar {
/**
* Aligns the sidebar to the right (true) or left (false) side
*/
"alignRight": boolean;
/**
* Name of the component
*/
"name"?: string;
/**
* Expands the sidebar
*/
"open": boolean;
}
interface InoSnackbar {
/**
* The text to display for the action button. If no text is defined, the snack bar is displayed in an alternative feedback style.
Expand Down Expand Up @@ -1451,10 +1437,6 @@ export interface InoSelectCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLInoSelectElement;
}
export interface InoSidebarCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLInoSidebarElement;
}
export interface InoSnackbarCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLInoSnackbarElement;
Expand Down Expand Up @@ -1718,12 +1700,6 @@ declare global {
prototype: HTMLInoSelectElement;
new (): HTMLInoSelectElement;
};
interface HTMLInoSidebarElement extends Components.InoSidebar, HTMLStencilElement {
}
var HTMLInoSidebarElement: {
prototype: HTMLInoSidebarElement;
new (): HTMLInoSidebarElement;
};
interface HTMLInoSnackbarElement extends Components.InoSnackbar, HTMLStencilElement {
}
var HTMLInoSnackbarElement: {
Expand Down Expand Up @@ -1818,7 +1794,6 @@ declare global {
"ino-segment-button": HTMLInoSegmentButtonElement;
"ino-segment-group": HTMLInoSegmentGroupElement;
"ino-select": HTMLInoSelectElement;
"ino-sidebar": HTMLInoSidebarElement;
"ino-snackbar": HTMLInoSnackbarElement;
"ino-spinner": HTMLInoSpinnerElement;
"ino-switch": HTMLInoSwitchElement;
Expand Down Expand Up @@ -2991,24 +2966,6 @@ declare namespace LocalJSX {
*/
"value"?: string;
}
interface InoSidebar {
/**
* Aligns the sidebar to the right (true) or left (false) side
*/
"alignRight"?: boolean;
/**
* Name of the component
*/
"name"?: string;
/**
* Emits an event if the user expands or collapses the sidebar
*/
"onOpenChange"?: (event: InoSidebarCustomEvent<any>) => void;
/**
* Expands the sidebar
*/
"open"?: boolean;
}
interface InoSnackbar {
/**
* The text to display for the action button. If no text is defined, the snack bar is displayed in an alternative feedback style.
Expand Down Expand Up @@ -3323,7 +3280,6 @@ declare namespace LocalJSX {
"ino-segment-button": InoSegmentButton;
"ino-segment-group": InoSegmentGroup;
"ino-select": InoSelect;
"ino-sidebar": InoSidebar;
"ino-snackbar": InoSnackbar;
"ino-spinner": InoSpinner;
"ino-switch": InoSwitch;
Expand Down Expand Up @@ -3378,7 +3334,6 @@ declare module "@stencil/core" {
"ino-segment-button": LocalJSX.InoSegmentButton & JSXBase.HTMLAttributes<HTMLInoSegmentButtonElement>;
"ino-segment-group": LocalJSX.InoSegmentGroup & JSXBase.HTMLAttributes<HTMLInoSegmentGroupElement>;
"ino-select": LocalJSX.InoSelect & JSXBase.HTMLAttributes<HTMLInoSelectElement>;
"ino-sidebar": LocalJSX.InoSidebar & JSXBase.HTMLAttributes<HTMLInoSidebarElement>;
"ino-snackbar": LocalJSX.InoSnackbar & JSXBase.HTMLAttributes<HTMLInoSnackbarElement>;
"ino-spinner": LocalJSX.InoSpinner & JSXBase.HTMLAttributes<HTMLInoSpinnerElement>;
"ino-switch": LocalJSX.InoSwitch & JSXBase.HTMLAttributes<HTMLInoSwitchElement>;
Expand Down
10 changes: 0 additions & 10 deletions packages/elements/src/components/ino-sidebar/MDCCustomDrawer.js

This file was deleted.

38 changes: 0 additions & 38 deletions packages/elements/src/components/ino-sidebar/ino-sidebar.e2e.ts

This file was deleted.

46 changes: 0 additions & 46 deletions packages/elements/src/components/ino-sidebar/ino-sidebar.scss

This file was deleted.

Loading

0 comments on commit 349b84d

Please sign in to comment.