Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ino-switch: support icons #686

Closed
janivo opened this issue Aug 3, 2022 · 0 comments · Fixed by #724
Closed

ino-switch: support icons #686

janivo opened this issue Aug 3, 2022 · 0 comments · Fixed by #724
Assignees
@TobiasHeimGalindo
Labels
feature This issue introduces a new feature
Milestone
Design Overhaul

Comments

@janivo
Copy link
Collaborator

janivo commented Aug 3, 2022 •
edited
Loading

  • Just like MDC, our ino-switch should be able to display two icons based on the checked state. Apply the new design of our designers to the component.
  • Use slots documented in the story of the ino-switch
  • should be worked on after ino-switch: Apply new Design #685
  • show states as stories
@janivo janivo added the feature This issue introduces a new feature label Aug 3, 2022
@janivo janivo added this to the Design 2.0 milestone Aug 3, 2022
@janivo janivo mentioned this issue Aug 4, 2022
Closed
@TobiasHeimGalindo TobiasHeimGalindo mentioned this issue Sep 6, 2022
Merged
github-actions bot pushed a commit that referenced this issue Oct 14, 2022
@TobiasHeimGalindo
Deploying unicorn elements-#686-ino-switch-support-icons 🦄
4cdbcfd
github-actions bot pushed a commit that referenced this issue Oct 19, 2022
@janivo
Deploying unicorn elements-#686-ino-switch-support-icons 🦄
052a34b
github-actions bot pushed a commit that referenced this issue Oct 20, 2022
@TobiasHeimGalindo
Deploying unicorn elements-#686-ino-switch-support-icons 🦄
5ef1cf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasHeimGalindo TobiasHeimGalindo

Labels
feature This issue introduces a new feature
Projects
None yet
Milestone
Design Overhaul
Development

Successfully merging a pull request may close this issue.

feat(elements|ino-switch): support icons inovex/elements
3 participants
@janivo @TobiasHeimGalindo @MariaLStefan