Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove color-scheme in all components #736

Closed
janivo opened this issue Sep 15, 2022 · 0 comments · Fixed by #756
Closed

Remove color-scheme in all components #736

janivo opened this issue Sep 15, 2022 · 0 comments · Fixed by #756
Assignees
@MariaLStefan

Comments

@janivo
Copy link
Collaborator

janivo commented Sep 15, 2022

The following components still use our deprecated color scheme:

  • ino-chip
  • ino-icon-button
  • ino-spinner

As we've discussed many times, we would like to get rid of these in order to promote the inovex brand colors and to reduce our maintenance costs.

Definition of done:

  • The properties have been removed in the remaining components
  • The type in types.ts has been removed
  • There are no SCSS references to the old color scheme
@MariaLStefan MariaLStefan self-assigned this Sep 28, 2022
@MariaLStefan MariaLStefan mentioned this issue Sep 29, 2022
Merged
janivo added a commit that referenced this issue Oct 19, 2022
@janivo
Merge branch 'master' into elements-#736-remove-color-schemes-in-all-…
a9e28c6 
…components

# Conflicts:
#	packages/elements/src/components.d.ts
#	packages/elements/src/components/ino-range/ino-range.scss
#	packages/elements/src/components/ino-range/ino-range.tsx
#	packages/elements/src/components/ino-range/readme.md
#	packages/elements/src/components/ino-switch/ino-switch.tsx
#	packages/elements/src/components/ino-switch/readme.md
#	packages/storybook/elements-stencil-docs.json
#	packages/storybook/src/stories/ino-chip/ino-chip.stories.ts
github-actions bot pushed a commit that referenced this issue Oct 19, 2022
@janivo
Deploying unicorn elements-#736-remove-color-schemes-in-all-components 🦄
a25da67
github-actions bot pushed a commit that referenced this issue Oct 19, 2022
@janivo
Deploying unicorn elements-#736-remove-color-schemes-in-all-components 🦄
021a772
janivo added a commit that referenced this issue Oct 24, 2022
@janivo
Merge branch 'master' into elements-#736-remove-color-schemes-in-all-…
9531978 
…components

# Conflicts:
#	yarn.lock
github-actions bot pushed a commit that referenced this issue Oct 24, 2022
@janivo
Deploying unicorn elements-#736-remove-color-schemes-in-all-components 🦄
e3b5763
@pfecht pfecht mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariaLStefan MariaLStefan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(elements): remove colorScheme from some components inovex/elements
2 participants
@janivo @MariaLStefan