Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elements): split ui-patterns into lib and playground package #1116

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat(elements): split ui-patterns into lib and playground package #1116

merged 4 commits into from
Dec 5, 2023

Conversation

TobiasHeimGalindo
Copy link
Collaborator

Closes #1100

@TobiasHeimGalindo TobiasHeimGalindo changed the title feat(elements): split ui-patterns into lib and playground package feat(ui-patterns): split ui-patterns into lib and playground package Nov 30, 2023
@TobiasHeimGalindo TobiasHeimGalindo changed the title feat(ui-patterns): split ui-patterns into lib and playground package feat(elements): split ui-patterns into lib and playground package Nov 30, 2023
janivo
janivo requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@janivo janivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 😎

Just one thing, the styles of tailwind seem to be missing in our playground app. You might need to import the stylesheet of the ui-patterns bundle in the root of the playground application.

image

@TobiasHeimGalindo
Copy link
Collaborator Author

Very cool 😎

Just one thing, the styles of tailwind seem to be missing in our playground app. You might need to import the stylesheet of the ui-patterns bundle in the root of the playground application.

image

ups, forgot the elements-react import. The Tailwind styles are applied correctly (see the change when removing @import '@inovex.de/ui-patterns/dist/style.css'; in the global css file index.css

Its fixed now

image

@janivo janivo merged commit f4cadea into master Dec 5, 2023
@janivo janivo deleted the elements-#1100-separate-patterns-and-app branch December 5, 2023 15:23
janivo pushed a commit that referenced this pull request Dec 5, 2023
@TobiasHeimGalindo @janivo
refactor(ui-patterns): split package into lib and playground (#1116)
99fbbc2
iandi09 pushed a commit that referenced this pull request Dec 22, 2023
@TobiasHeimGalindo @iandi09
refactor(ui-patterns): split package into lib and playground (#1116)
8c320ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janivo janivo janivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui-Patterns: Separate app and patterns
2 participants
@TobiasHeimGalindo @janivo