Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cm6.js #50

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Update cm6.js #50

merged 13 commits into from
Feb 21, 2024

Conversation

bhsd-harry
Copy link
Member

大更新,现在用户可自选开启的CodeMirror 6插件

大更新,现在用户可自选开启的CodeMirror 6插件
Copy link

cloudflare-workers-and-pages bot commented Feb 1, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4dfd22f
Status: ✅  Deploy successful!
Preview URL: https://8bc3d00b.inpageedit-plugins.pages.dev
Branch Preview URL: https://bhsd-harry-cm6.inpageedit-plugins.pages.dev

View logs

@bhsd-harry
Copy link
Member Author

@dragon-fish 如果要转正的话,覆盖移动到script.js吗?

src/plugins/code-mirror/style.css Outdated Show resolved Hide resolved
@dragon-fish
Copy link
Member

Plugins/src/index.json

Lines 26 to 30 in 3d46a1c

"code-mirror/cm6.js": {
"name": "[BETA] CodeMirror 6",
"description": "Syntaxhighlight editor for InPageEdit. Currently supported languages: Wikitext, CSS, JavaScript, JSON, Lua. In conflict with CodeMirror 5.",
"author": "InPageEdit"
},

怎么说

@bhsd-harry
Copy link
Member Author

稍等,那我还是先revert回去吧。

@dragon-fish
Copy link
Member

Plugins/src/index.json

Lines 26 to 30 in 3d46a1c

"code-mirror/cm6.js": {
"name": "[BETA] CodeMirror 6",
"description": "Syntaxhighlight editor for InPageEdit. Currently supported languages: Wikitext, CSS, JavaScript, JSON, Lua. In conflict with CodeMirror 5.",
"author": "InPageEdit"
},

怎么说

目前 IPE 还没有自动移除失效插件的能力,这是设计上的缺陷,要么就保留 cm6.js 这个文件,内容换成加载 script.js

@bhsd-harry
Copy link
Member Author

我想了想CM6还是先保留BETA吧,再等一段时间的用户反馈。

Copy link
Member

@dragon-fish dragon-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

给CM5版本也加上边框
Copy link

@dragon-fish
Copy link
Member

@bhsd-harry bhsd-harry merged commit 8792015 into master Feb 21, 2024
2 checks passed
@bhsd-harry bhsd-harry deleted the bhsd-harry/cm6 branch February 21, 2024 03:04
@dragon-fish
Copy link
Member

要不同步更新一下文档,简单讲一下怎么配置 cm6?

https://github.com/inpageedit/Documentation/blob/b4f753f5a8d2dd4760dd2b7f0df5e25265c62056/src/guide/usage/preference.md?plain=1#L39

也可以另开一个“插件”主题,把 CodeMirror 的文档移进去

@bhsd-harry
Copy link
Member Author

要不同步更新一下文档,简单讲一下怎么配置 cm6?

CM6有一个固有缺陷,无法从外部更换样式,这个我得先观望一下MW的人怎么解决。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants