Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes modulartabler's dependency on
data.table
in lieu oftidyr
pivoting. This comes with a couple of benefits:convert_tabular()
now uses reshaping functions fromtidyr
. This means we do not have to coerce multiple measures to the same type, as happens withmelt
/dcast
.tidyr
is compatible withvctrs
classes, like in maskr which I plan to implement later.dbplyr
,dtplyr
,duckplyr
and other lazy-evaluation pipeline packages.This does result in some losses:
conversion
shim argument to convert measures before reshaping. This was used to prevent a warning fromdata.table
, so is not as important now.value_override
argument, which was used to create a suppression mask table. This will not be required when maskr gets introduced, so is hopefully only a temporary loss.This also provided an opportunity to add examples and improve documentation.