Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data.table dependency #3

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Remove data.table dependency #3

merged 11 commits into from
Aug 19, 2024

Conversation

inpowell
Copy link
Owner

This PR removes modulartabler's dependency on data.table in lieu of tidyr pivoting. This comes with a couple of benefits:

  1. convert_tabular() now uses reshaping functions from tidyr. This means we do not have to coerce multiple measures to the same type, as happens with melt/dcast.
  2. tidyr is compatible with vctrs classes, like in maskr which I plan to implement later.
  3. We will gain (a better shot) at compatibility with dbplyr, dtplyr, duckplyr and other lazy-evaluation pipeline packages.

This does result in some losses:

  1. There is no conversion shim argument to convert measures before reshaping. This was used to prevent a warning from data.table, so is not as important now.
  2. There is no value_override argument, which was used to create a suppression mask table. This will not be required when maskr gets introduced, so is hopefully only a temporary loss.

This also provided an opportunity to add examples and improve documentation.

@inpowell inpowell merged commit 400742f into master Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant