Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't destroy and recreate subnets when their availability zone changes in the terraform config #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaii-zen
Copy link
Contributor

A subnet's availability zone can change in the terraform config in a couple of scenarios I can think of:

  1. Updating Bitte on an old deployment that was not properly spread across availability zones.
  2. (hypothetical) upstream changes to amazon's availability-zone/instance-type support matrix cause the terraform config logic to come up with different subnet->availability zone assignments.

In scenario 1 we may want to follow through with the change set to spread our instances across azs as per best practices, while in scenario 2 it is probably not worth the trouble.

Separating this from #154 so that we can decide on it in isolation.

Copy link
Contributor

@johnalotoski johnalotoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this does suppress all AZ re-arrangement changes for the cores.
Is there a similar change for clients to be done also?
Client plan still shows a large diff of AZ re-arrangement destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants