refactor(governance)!: Aligned package with updates to CIP-36 #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CIP-36 (Catalyst/Voltaire Registration Transaction Metadata Format (Updated)) has seen some a couple recent changes:
reward_address
field withpayment_address
. Wherepayment_address
contains a payment address rather than stake/rewards address. To accompany this new test vectors were supplied.Proposed Solution
votingKey
to useCIP36VoteKey
.Important Changes Introduced
interface VotingKeyDerivationPath
to beinterface CIP36VoteKeyDerivationPath
.interface GovernanceKeyDelegation
to beinterface VoteKeyDelegation
.interface GovernanceKeyDelegation
I renamedvotingKey
to becip36VoteKey
.interface BuildVotingRegistrationProps
I replacedrewardAccount
withpaymentAddress
and changed the type to be aCardano.Address
rather thanCardano.RewardAccount
.votingKey
toCIP36VoteKey
.