This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 629
[DEVOPS-810] [DEVOPS-908] Inject gitrev using file-embed #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
requested review from
adinapoli-iohk,
akegalj,
denisshevchenko,
erikd,
iohk-devops,
ksaric and
parsonsmatt
as code owners
June 25, 2018 16:35
rvl
removed request for
erikd,
akegalj,
denisshevchenko,
ksaric,
parsonsmatt and
adinapoli-iohk
June 25, 2018 16:39
I like where you're going with this. Using
How so? I also like how it simplifies the |
rvl
force-pushed
the
devops-908-test-all
branch
3 times, most recently
from
June 26, 2018 06:04
123467b
to
f5d411b
Compare
rvl
changed the title
WIP [DEVOPS-810] [DEVOPS-908] Inject gitrev using file-embed
[DEVOPS-810] [DEVOPS-908] Inject gitrev using file-embed
Jun 26, 2018
Have fixed the |
It now builds all tests and benchmarks, and runs all tests. Issue was brought up in FP Complete's Cardano Report (12 April 2018).
So that this package gets built as part of all-cardano-sl.
The build shouldn't depend on the presence of git on the PATH. If git is unavailable, use an obvious null revision.
This will prevent needless rebuilds of cabal packages because the git revision is injected after the nix package build.
jmitchell
approved these changes
Jun 26, 2018
parsonsmatt
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it!
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
[DEVOPS-810] [DEVOPS-908] Inject gitrev using file-embed
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/devops-908-test-all [DEVOPS-810] [DEVOPS-908] Inject gitrev using file-embed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the problem of nix rebuilds with identical sources but different git revisions. It doesn't require creating extra cabal projects. The code in utils gets a little simpler as well. The code could get even more simpler if
HasCompileInfo
were removed -- maybe I should do that?There is also the addition of an
all-cardano-sl
attribute.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-810
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-908
Type of change
Developer checklist
Testing checklist
QA Steps