-
Notifications
You must be signed in to change notification settings - Fork 629
[DEVOPS-1032] nix: Add flag to build with optimization disabled #3544
Conversation
d7fc405
to
d9a6951
Compare
Rebased on latest develop with temp testing commits removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment improvement request. Otherwise, LGTM!
default.nix
Outdated
@@ -111,6 +112,14 @@ let | |||
}); | |||
}; | |||
|
|||
# Disabling optimization for cardano-sl packages will | |||
# return a build x% faster (measured in DEVOPS-1032). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the issue both mine and Rodney's experiments outside Hydra with cache invalidation (echo >> util/cardano-sl-util.cabal
) shows ~20% speedup for all-cardano-sl
when optimization is disabled.
On that basis, let's s/x%/20%/
here. input-output-hk/iohk-ops#418 takes care of passing fasterBuild = true;
in the Hydra jobset only for PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK yes I have amended the commit to add that figure.
Used like this: nix-build --arg fasterBuild true -A cardano-sl-wallet-new
d9a6951
to
d1dd6fa
Compare
@jmitchell I realised that I forgot to pass through the argument in I have pushed another commit and tested |
Description
Adds a
fasterBuild
argument to the nix build. This will result in-O0
being passed to GHC. This can be enabled for PR builds (see input-output-hk/iohk-ops#418) to get quicker turnaround.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1032